From 22b6d2f30cb1d5a0e7b4f1385ddba79e59dc0b34 Mon Sep 17 00:00:00 2001 From: Dries Buytaert Date: Sat, 12 Jul 2003 22:21:55 +0000 Subject: - Performance improvement: changed a fair amount of "left joins" to "inner joins". Patch by Gerhard. --- modules/import.module | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'modules/import.module') diff --git a/modules/import.module b/modules/import.module index b8f500720..59847de0b 100644 --- a/modules/import.module +++ b/modules/import.module @@ -499,7 +499,7 @@ function import_get_bundle($bid) { } function import_view() { - $result = db_query("SELECT f.*, COUNT(i.iid) AS items FROM {feed} f LEFT JOIN {item} i ON f.fid = i.fid GROUP BY f.fid, f.title, f.url, f.refresh, f.timestamp, f.attributes, f.link, f.description ORDER BY f.title"); + $result = db_query("SELECT f.*, COUNT(i.iid) AS items FROM {feed} f INNER JOIN {item} i ON f.fid = i.fid GROUP BY f.fid, f.title, f.url, f.refresh, f.timestamp, f.attributes, f.link, f.description ORDER BY f.title"); $output .= "

Feed overview

"; @@ -526,7 +526,7 @@ function import_view() { function import_tag() { - $result = db_query_range("SELECT i.*, f.title AS feed FROM {item} i LEFT JOIN {feed} f ON i.fid = f.fid ORDER BY i.iid DESC", 0, 50); + $result = db_query_range("SELECT i.*, f.title AS feed FROM {item} i INNER JOIN {feed} f ON i.fid = f.fid ORDER BY i.iid DESC", 0, 50); $header = array(t("date"), t("feed"), t("news item")); while ($item = db_fetch_object($result)) { @@ -619,7 +619,7 @@ function import_page_info() { function import_page_last() { - $result = db_query_range("SELECT i.*, f.title AS ftitle, f.link AS flink FROM {item} i LEFT JOIN {feed} f ON i.fid = f.fid ORDER BY i.iid DESC", 0, variable_get("import_page_limit", 75)); + $result = db_query_range("SELECT i.*, f.title AS ftitle, f.link AS flink FROM {item} i INNER JOIN {feed} f ON i.fid = f.fid ORDER BY i.iid DESC", 0, variable_get("import_page_limit", 75)); $output .= ""; while ($item = db_fetch_object($result)) { -- cgit v1.2.3