From dc4d421be78c471017fd8cf0d3b7986147844dab Mon Sep 17 00:00:00 2001 From: Dries Buytaert Date: Fri, 22 May 2009 11:33:18 +0000 Subject: - Patch #396284 by Berdir, chx, jcfiala, csevb10 et al: make sure to order by table headers first, before ordering by other fields. --- modules/statistics/statistics.admin.inc | 8 ++++---- modules/statistics/statistics.pages.inc | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'modules/statistics') diff --git a/modules/statistics/statistics.admin.inc b/modules/statistics/statistics.admin.inc index 9d776058c..ed225dbfc 100644 --- a/modules/statistics/statistics.admin.inc +++ b/modules/statistics/statistics.admin.inc @@ -23,7 +23,7 @@ function statistics_recent_hits() { ->fields('a', array('aid', 'timestamp', 'path', 'title', 'uid')) ->fields('u', array('name')) ->limit(30) - ->setHeader($header); + ->orderByHeader($header); $result = $query->execute(); $rows = array(); @@ -66,7 +66,7 @@ function statistics_top_pages() { ->fields('accesslog', array('path')) ->groupBy('path') ->limit(30) - ->setHeader($header); + ->orderByHeader($header); $count_query = db_select('accesslog'); $count_query->addExpression('COUNT(DISTINCT path)'); @@ -114,7 +114,7 @@ function statistics_top_visitors() { ->groupBy('u.name') ->groupBy('bl.iid') ->limit(30) - ->setHeader($header); + ->orderByHeader($header); $count_query = db_select('accesslog'); $count_query->addExpression('COUNT(DISTINCT CONCAT(CAST(uid AS char), hostname))'); @@ -159,7 +159,7 @@ function statistics_top_referrers() { ->condition('url', '', '<>') ->groupBy('url') ->limit(30) - ->setHeader($header); + ->orderByHeader($header); $count_query = db_select('accesslog'); $count_query->addExpression('COUNT(DISTINCT url)'); diff --git a/modules/statistics/statistics.pages.inc b/modules/statistics/statistics.pages.inc index ce508cf61..e0c3b5ac3 100644 --- a/modules/statistics/statistics.pages.inc +++ b/modules/statistics/statistics.pages.inc @@ -25,7 +25,7 @@ function statistics_node_tracker() { ->condition('a.path', 'node/' . $node->nid) ->condition('a.path', 'node/' . $node->nid . '/%', 'LIKE')) ->limit(30) - ->setHeader($header); + ->orderByHeader($header); $result = $query->execute(); $rows = array(); @@ -64,7 +64,7 @@ function statistics_user_tracker() { ->fields('a', array('aid', 'timestamp', 'path', 'title')) ->condition('uid', $account->uid) ->limit(30) - ->setHeader($header); + ->orderByHeader($header); $result = $query->execute(); $rows = array(); -- cgit v1.2.3