From de7e1fb66aea6cced3349f0bebc020b3485cdd7c Mon Sep 17 00:00:00 2001 From: Dries Buytaert Date: Sat, 24 Mar 2001 16:26:56 +0000 Subject: - fixed potential quote problem: wrapped $story->section in a check_output - removed all $story->update related logic - the update field is redundant --- themes/example/example.theme | 30 ++++++++++++++---------------- themes/goofy/goofy.theme | 8 +++----- themes/jeroen/jeroen.theme | 6 ++---- themes/unconed/unconed.theme | 12 +++++------- 4 files changed, 24 insertions(+), 32 deletions(-) (limited to 'themes') diff --git a/themes/example/example.theme b/themes/example/example.theme index bea81f153..73037482e 100644 --- a/themes/example/example.theme +++ b/themes/example/example.theme @@ -8,11 +8,11 @@ ?> - + <? echo $site_name; ?> - + @@ -20,7 +20,7 @@ Logo? + "; echo "
-
@@ -43,7 +43,7 @@ @@ -58,7 +58,7 @@ @@ -118,7 +116,7 @@ echo " "; echo " "; echo " "; - + // Print body of comment: if ($comment) echo " "; - + // Print bottom link(s): echo " "; echo "
- subject); ?> + title); ?>
section) ."\">$story->section"; + echo "section) ."\">". check_output($story->section) .""; ?> @@ -68,12 +68,10 @@ ". check_output($story->abstract, 1) ."

"; - if ($story->updates) - echo "

". t("Editor's note by editor\">$story->editor") .":". check_output($story->updates, 1) ."

"; if ($reply) - echo "

". check_output($story->article, 1) ."

"; + echo "

". check_output($story->article, 1) ."

"; ?>
"; echo " "; - + // Subject: echo " "; echo " "; - + // Moderation: echo " "; echo " "; - + // Author: echo " "; echo " "; echo " "; - + echo "
"; @@ -127,13 +125,13 @@ echo " "; echo " ". check_output($comment->subject); echo " "; echo comment_moderation($comment); echo "
". t("Author") .":". format_username($comment->userid); @@ -142,14 +140,14 @@ echo " on ". format_date($comment->timestamp); echo "
"; echo "
" . check_output($comment->comment, 1) ."
$link
"; @@ -160,7 +158,7 @@ echo "
"; echo "
"; - + } // close comment function function box($subject, $content, $options = "") { diff --git a/themes/goofy/goofy.theme b/themes/goofy/goofy.theme index 01ac5d5cd..6793e2c15 100644 --- a/themes/goofy/goofy.theme +++ b/themes/goofy/goofy.theme @@ -91,7 +91,7 @@ function story($story, $reply = 0) { - echo "\n\n"; + echo "\n\n"; ?> @@ -102,7 +102,7 @@ - + @@ -118,7 +118,7 @@ - + @@ -126,8 +126,6 @@ @@ -116,7 +116,7 @@
subject); ?>title); ?>
format_username($story->userid), "%b" => format_date($story->timestamp, "large"))); ?>
section) ."\">$story->section"; ?>
section) ."\">". check_output($story->section) .""; ?>

abstract, 1) ."

"; - if ($story->updates) - echo t("Editor's note by editor\">$story->editor") .":". check_output($story->updates, 1) ."

"; if ($reply) echo check_output($story->article, 1); ?> diff --git a/themes/jeroen/jeroen.theme b/themes/jeroen/jeroen.theme index 39a0e8776..db665f810 100644 --- a/themes/jeroen/jeroen.theme +++ b/themes/jeroen/jeroen.theme @@ -85,7 +85,7 @@
" nowrap>  - subject) .""; ?> + title) .""; ?> " nowrap> 
- section) ."\">$story->section"; + section) ."\">". check_output($story->section) .""; ?> @@ -128,8 +128,6 @@ ". check_output($story->abstract, 1) ."
"; - if ($story->updates) - echo "

". t("Editor's note by editor\">$story->editor") .":". check_output($story->updates, 1) ."

"; if ($reply) echo "
". check_output($story->article, 1) ."
"; diff --git a/themes/unconed/unconed.theme b/themes/unconed/unconed.theme index 7bbcc5367..3b3f61a79 100644 --- a/themes/unconed/unconed.theme +++ b/themes/unconed/unconed.theme @@ -1,14 +1,14 @@ brcolor1; ?>" WIDTH="100%">
- + section) { print " @@ -102,8 +102,6 @@
subject, 1) .""; ?>
title) .""; ?>
bgcolor2\">"; } @@ -94,7 +94,7 @@ if ($story->userid) { print "Posted by " . format_username($story->userid) . " on $timestamp"; } else { print "Posted by $anonymous on $timestamp"; } - if ($story->section) { print "bgcolor2\" ALIGN=\"center\">section) . "\">sectioncolor\">$story->section"; } + if ($story->section) { print "bgcolor2\" ALIGN=\"center\">section) . "\">sectioncolor\">". check_output($story->section) .""; } ?>
". check_output($story->abstract, 1) ."

"; - if ($story->updates) - echo "

fgcolor3\">Editor's note by " . format_username($editor) . ": ". check_output($story->updates, 1) ."

"; if ($reply) if ($story->article) print "

". check_output($story->article, 1) ."

\n"; ?> -- cgit v1.2.3