JS checks for .hasOwnProperty

This patch includes
- several helper functions - is* checks
- hasOwnProperty method emulator
- checks for .hasOwnProperty in all for..in loops

darcs-hash:20070111114236-00f02-50a71681e5d04faf086f1b8032a384648378b744.gz

4 files changed, 4 insertions, 0 deletions

diff --git a/lib/exe/js.php b/lib/exe/js.php
index 3ed69b476..15cdc6506 100644
--- a/lib/exe/js.php
+++ b/lib/exe/js.php
@@ -39,6 +39,7 @@ function js_out(){
 
     // Array of needed files
     $files = array(
+                DOKU_INC.'lib/scripts/helpers.js',
                 DOKU_INC.'lib/scripts/events.js',
                 DOKU_INC.'lib/scripts/cookie.js',
                 DOKU_INC.'lib/scripts/script.js',
diff --git a/lib/scripts/cookie.js b/lib/scripts/cookie.js
index c236eeb79..d7e6b3550 100644
--- a/lib/scripts/cookie.js
+++ b/lib/scripts/cookie.js
@@ -29,6 +29,7 @@ DokuCookie = {
         //save the whole data array
         var text = '';
         for(var key in DokuCookie.data){
+            if (!DokuCookie.data.hasOwnProperty(key)) continue;
             text += '#'+escape(key)+'#'+DokuCookie.data[key];
         }
         DokuCookie.setCookie(DokuCookie.name,text.substr(1),now,DOKU_BASE);
diff --git a/lib/scripts/edit.js b/lib/scripts/edit.js
index 077069a5a..19e31e2ad 100644
--- a/lib/scripts/edit.js
+++ b/lib/scripts/edit.js
@@ -57,6 +57,7 @@ function createPicker(id,list,icobase,edid){
     picker.style.display  = 'none';
 
     for(var key in list){
+        if (!list.hasOwnProperty(key)) continue;
         var btn = document.createElement('button');
 
         btn.className = 'pickerbutton';
diff --git a/lib/scripts/events.js b/lib/scripts/events.js
index 33bd1429e..907526375 100644
--- a/lib/scripts/events.js
+++ b/lib/scripts/events.js
@@ -40,6 +40,7 @@ function handleEvent(event) {
     var handlers = this.events[event.type];
     // execute each event handler
     for (var i in handlers) {
+        if (!handlers.hasOwnProperty(i)) continue;
         this.$$handleEvent = handlers[i];
         if (this.$$handleEvent(event) === false) {
             returnValue = false;