Fix umask bug and do a code cleanup of chmod/mkdir usage so set the correct permissions, this should also fix problems with dokuwiki making setuid files on some umasks.

  * Don't set the umask() anymore, this is not good form and we don't really know what is it in the old code anyway as it was not done properly.
  * Retire the dmask config option introduce 2 new ones called fmode and dmode, this is more in line with posix and should make more sense.
  * Use chmod for setting the correct permissions but only if it's needed.
  * Set changing of permissions off by default as i should work properly in most Apache setups without and it does not make sense on windows anyway.

darcs-hash:20060224211655-ee6b9-68f7bb59417d6f0033cfd3764146923daa4dcf1b.gz

1 files changed, 0 insertions, 2 deletions

diff --git a/inc/common.php b/inc/common.php
index ef36593ab..cef8a0ab0 100644
--- a/inc/common.php
+++ b/inc/common.php
@@ -810,7 +810,6 @@ function getRevisionInfo($id,$rev){
 function saveWikiText($id,$text,$summary,$minor=false){
   global $conf;
   global $lang;
-  umask($conf['umask']);
   // ignore if no changes were made
   if($text == rawWiki($id,'')){
     return;
@@ -857,7 +856,6 @@ function saveWikiText($id,$text,$summary,$minor=false){
  */
 function saveOldRevision($id){
   global $conf;
-  umask($conf['umask']);
   $oldf = wikiFN($id);
   if(!@file_exists($oldf)) return '';
   $date = filemtime($oldf);