diff options
author | Andreas Gohr <andi@splitbrain.org> | 2009-10-17 20:03:29 +0200 |
---|---|---|
committer | Andreas Gohr <andi@splitbrain.org> | 2009-10-17 20:03:29 +0200 |
commit | 8cc02d2f62a570ffd365bfbefdbbafb0189443f1 (patch) | |
tree | abf1b6510c6bff224674065291ba8b6f6f47474b /lib/scripts/edit.js | |
parent | 31f197d78fc3c5a2cd03542e07f1dda69f15a630 (diff) | |
download | rpg-8cc02d2f62a570ffd365bfbefdbbafb0189443f1.tar.gz rpg-8cc02d2f62a570ffd365bfbefdbbafb0189443f1.tar.bz2 |
Some JS cleanup, keep accesskeys working for hidden pickers FS#1761
Ignore-this: 3b6c8568615d24be7115adf8570f56bd
darcs-hash:20091017180329-7ad00-9ff4a12c811f1a4c63e473dc6665928fda720850.gz
Diffstat (limited to 'lib/scripts/edit.js')
-rw-r--r-- | lib/scripts/edit.js | 37 |
1 files changed, 12 insertions, 25 deletions
diff --git a/lib/scripts/edit.js b/lib/scripts/edit.js index 58fef43e8..74dc1b521 100644 --- a/lib/scripts/edit.js +++ b/lib/scripts/edit.js @@ -1,7 +1,7 @@ /** * Functions for text editing (toolbar stuff) * - * @todo I'm no JS guru please help if you know how to improve + * @todo most of the stuff in here should be revamped and then moved to toolbar.js * @author Andreas Gohr <andi@splitbrain.org> */ @@ -67,7 +67,7 @@ function createPicker(id,props,edid){ } picker.id = id; picker.style.position = 'absolute'; - picker.style.display = 'none'; + picker.style.left = '-10000px'; // no display none, to keep access keys working for(var key in list){ if (!list.hasOwnProperty(key)) continue; @@ -124,24 +124,6 @@ function pickerInsert(text,edid){ } /** - * Show a previosly created picker window - * - * @author Andreas Gohr <andi@splitbrain.org> - */ -function showPicker(pickerid,btn){ - var picker = document.getElementById(pickerid); - var x = findPosX(btn); - var y = findPosY(btn); - if(picker.style.display == 'none'){ - picker.style.display = 'block'; - picker.style.left = (x+3)+'px'; - picker.style.top = (y+btn.offsetHeight+3)+'px'; - }else{ - picker.style.display = 'none'; - } -} - -/** * Add button action for signature button * * @param DOMElement btn Button element to add the action to @@ -162,7 +144,6 @@ function addBtnActionSignature(btn, props, edid) return false; } - /** * Add button action for the mediapopup button * @@ -171,8 +152,7 @@ function addBtnActionSignature(btn, props, edid) * @return boolean If button should be appended * @author Gabriel Birke <birke@d-scribe.de> */ -function addBtnActionMediapopup(btn, props) -{ +function addBtnActionMediapopup(btn, props) { eval("btn.onclick = function(){window.open('"+DOKU_BASE+ jsEscape(props['url']+encodeURIComponent(NS))+"','"+ jsEscape(props['name'])+"','"+ @@ -181,8 +161,15 @@ function addBtnActionMediapopup(btn, props) return true; } -function addBtnActionAutohead(btn, props, edid, id) -{ +/** + * Add button action for the headline buttons + * + * @param DOMElement btn Button element to add the action to + * @param array props Associative array of button properties + * @return boolean If button should be appended + * @author Andreas Gohr <gohr@cosmocode.de> + */ +function addBtnActionAutohead(btn, props, edid, id) { eval("btn.onclick = function(){"+ "insertHeadline('"+edid+"',"+props['mod']+",'"+jsEscape(props['text'])+"'); "+ "return false};"); |