From c1272e0334c0f9a6b7bdf86c7489e82aaeb01aa5 Mon Sep 17 00:00:00 2001
From: Andreas Gohr <andi@splitbrain.org>
Date: Fri, 16 Mar 2012 00:38:36 +0100
Subject: some code sniffer rule adjustments

---
 _cs/DokuWiki/ruleset.xml | 88 +++++++++++++++++++++++++-----------------------
 1 file changed, 46 insertions(+), 42 deletions(-)

(limited to '_cs')

diff --git a/_cs/DokuWiki/ruleset.xml b/_cs/DokuWiki/ruleset.xml
index 5efa6bf06..4135c0860 100644
--- a/_cs/DokuWiki/ruleset.xml
+++ b/_cs/DokuWiki/ruleset.xml
@@ -2,48 +2,52 @@
 <ruleset name="DokuWiki">
     <description>DokuWiki Coding Standard</description>
 
-            <rule ref="Generic.Classes.DuplicateClassName" />,
-            <rule ref="Generic.CodeAnalysis.JumbledIncrementer" />,
-            <rule ref="Generic.CodeAnalysis.UnnecessaryFinalModifier" />,
-            <rule ref="Generic.CodeAnalysis.UnconditionalIfStatement" />,
-            <rule ref="Generic.CodeAnalysis.ForLoopShouldBeWhileLoop" />,
-            <rule ref="Generic.CodeAnalysis.ForLoopWithTestFunctionCall" />,
-            <rule ref="Generic.CodeAnalysis.UnusedFunctionParameter" />,
-            <rule ref="Generic.CodeAnalysis.EmptyStatement" />,
-            <rule ref="Generic.CodeAnalysis.UselessOverridingMethod" />,
-            <rule ref="Generic.Commenting.Todo" />,
-            <rule ref="Generic.Files.LineEndings" />,
-            <rule ref="Generic.Formatting.DisallowMultipleStatements" />,
-            <rule ref="Generic.Metrics.NestingLevel" />,
-<!--            <rule ref="Generic./Metrics/CyclomaticComplexity" />, //FIXME we might need to tune this first -->
-            <rule ref="Generic.NamingConventions.UpperCaseConstantName" />,
-            <rule ref="Generic.PHP.LowerCaseConstant" />,
-            <rule ref="Generic.PHP.DisallowShortOpenTag" />,
-            <rule ref="Generic.PHP.ForbiddenFunctions" />,
-            <rule ref="Generic.WhiteSpace.DisallowTabIndent" />,
-            <rule ref="DokuWiki.WhiteSpace.ScopeIndent" />,
-            <rule ref="Zend.Files.ClosingTag" />,
-            <rule ref="PEAR.Functions.ValidDefaultValue" />,
-            <rule ref="Squiz.PHP.Eval" />,
-            <rule ref="Squiz.PHP.NonExecutableCode" />,
-<!--            <rule ref="Squiz./PHP/CommentedOutCode" />, //FIXME should ignore oneliners -->
-            <rule ref="Squiz.WhiteSpace.SuperfluousWhitespace" />,
-            <rule ref="Squiz.PHP.NonExecutableCode" />,
-            <rule ref="Squiz.CSS.LowercaseStyleDefinition" />,
-            <rule ref="Squiz.CSS.MissingColon" />,
-            <rule ref="Squiz.CSS.DisallowMultipleStyleDefinitions" />,
-            <rule ref="Squiz.CSS.ColonSpacing" />,
-            <rule ref="Squiz.CSS.ClassDefinitionClosingBraceSpace" />,
-            <rule ref="Squiz.CSS.SemicolonSpacing" />,
-            <rule ref="Squiz.CSS.Indentation" />,
-            <rule ref="Squiz.CSS.EmptyClassDefinition" />,
-            <rule ref="Squiz.CSS.ClassDefinitionNameSpacing" />,
-            <rule ref="Squiz.CSS.EmptyStyleDefinition" />,
-            <rule ref="Squiz.CSS.Opacity" />,
-            <rule ref="Squiz.CSS.ColourDefinition" />,
-            <rule ref="Squiz.CSS.DuplicateClassDefinition" />,
-            <rule ref="Squiz.CSS.ClassDefinitionOpeningBraceSpace" />,
+        <rule ref="Generic.NamingConventions.ConstructorName" />
+        <rule ref="Generic.Classes.DuplicateClassName" />
+        <rule ref="Generic.CodeAnalysis.JumbledIncrementer" />
+        <rule ref="Generic.CodeAnalysis.UnnecessaryFinalModifier" />
+        <rule ref="Generic.CodeAnalysis.UnconditionalIfStatement" />
+        <rule ref="Generic.CodeAnalysis.ForLoopShouldBeWhileLoop" />
+        <rule ref="Generic.CodeAnalysis.ForLoopWithTestFunctionCall" />
+        <rule ref="Generic.CodeAnalysis.UnusedFunctionParameter" />
+        <rule ref="Generic.CodeAnalysis.EmptyStatement" />
+        <rule ref="Generic.CodeAnalysis.UselessOverridingMethod" />
+        <rule ref="Generic.Commenting.Todo" />
+        <ruke ref="Generic.Files.ByteOrderMark" />
+        <rule ref="Generic.Files.LineEndings" />
+        <rule ref="Generic.Formatting.DisallowMultipleStatements" />
+        <rule ref="Generic.Metrics.NestingLevel" />
+<!--            <rule ref="Generic./Metrics/CyclomaticComplexity" /> //FIXME we might need to tune this first -->
+        <rule ref="Generic.NamingConventions.UpperCaseConstantName" />
+        <rule ref="Generic.PHP.LowerCaseConstant" />
+        <rule ref="Generic.PHP.DeprecatedFunctions.php" />
+        <rule ref="Generic.PHP.DisallowShortOpenTag" />
+        <!-- Overridden rule ref="Generic.PHP.ForbiddenFunctions" /-->
+        <rule ref="Generic.WhiteSpace.DisallowTabIndent" />
+        <rule ref="Generic.Classes.DuplicateClassName" />
+        <rule ref="Generic.Functions.CallTimePassByReference" />
+        <rule ref="Zend.Files.ClosingTag" />
+        <rule ref="PEAR.Functions.ValidDefaultValue" />
+        <rule ref="Squiz.PHP.Eval" />
+        <rule ref="Squiz.PHP.NonExecutableCode" />
+<!--            <rule ref="Squiz./PHP/CommentedOutCode" /> //FIXME should ignore oneliners -->
+        <rule ref="Squiz.WhiteSpace.SuperfluousWhitespace" />
+        <rule ref="Squiz.PHP.NonExecutableCode" />
+        <rule ref="Squiz.CSS.LowercaseStyleDefinition" />
+        <rule ref="Squiz.CSS.MissingColon" />
+        <rule ref="Squiz.CSS.DisallowMultipleStyleDefinitions" />
+        <rule ref="Squiz.CSS.ColonSpacing" />
+        <rule ref="Squiz.CSS.ClassDefinitionClosingBraceSpace" />
+        <rule ref="Squiz.CSS.SemicolonSpacing" />
+        <rule ref="Squiz.CSS.Indentation" />
+        <rule ref="Squiz.CSS.EmptyClassDefinition" />
+        <rule ref="Squiz.CSS.ClassDefinitionNameSpacing" />
+        <rule ref="Squiz.CSS.EmptyStyleDefinition" />
+        <rule ref="Squiz.CSS.Opacity" />
+        <rule ref="Squiz.CSS.ColourDefinition" />
+        <rule ref="Squiz.CSS.DuplicateClassDefinition" />
+        <rule ref="Squiz.CSS.ClassDefinitionOpeningBraceSpace" />
 
-            <rule ref="Squiz.Commenting.DocCommentAlignment" />,
+        <rule ref="Squiz.Commenting.DocCommentAlignment" />
 
 </ruleset>
-- 
cgit v1.2.3