From 44881d272282937c9bb745f462c947319d404dd0 Mon Sep 17 00:00:00 2001 From: Troels Liebe Bentsen Date: Fri, 24 Feb 2006 22:16:55 +0100 Subject: Fix umask bug and do a code cleanup of chmod/mkdir usage so set the correct permissions, this should also fix problems with dokuwiki making setuid files on some umasks. * Don't set the umask() anymore, this is not good form and we don't really know what is it in the old code anyway as it was not done properly. * Retire the dmask config option introduce 2 new ones called fmode and dmode, this is more in line with posix and should make more sense. * Use chmod for setting the correct permissions but only if it's needed. * Set changing of permissions off by default as i should work properly in most Apache setups without and it does not make sense on windows anyway. darcs-hash:20060224211655-ee6b9-68f7bb59417d6f0033cfd3764146923daa4dcf1b.gz --- lib/plugins/plugin/admin.php | 1 - 1 file changed, 1 deletion(-) (limited to 'lib/plugins/plugin') diff --git a/lib/plugins/plugin/admin.php b/lib/plugins/plugin/admin.php index 7715d10ff..92df52b61 100644 --- a/lib/plugins/plugin/admin.php +++ b/lib/plugins/plugin/admin.php @@ -587,7 +587,6 @@ class ap_manage { function ap_mkdir($d) { global $conf; - umask($conf['umask']); $ok = io_mkdir_p($d); return $ok; } -- cgit v1.2.3