From e8b5a4f91c8a6e230a6cfe13c43dc9ddce31e253 Mon Sep 17 00:00:00 2001 From: Andreas Gohr Date: Sat, 28 Jul 2012 12:02:06 +0200 Subject: fix E_STRICT errors FS#2427 This commit fixes all E_STRICT messages shown when running the test suite. There might be more problems not covered by tests, yet. For compatibility reasons with plugins, E_STRICT errors are still supressed. --- lib/plugins/action.php | 2 +- lib/plugins/popularity/action.php | 2 +- lib/plugins/safefnrecode/action.php | 2 +- lib/plugins/testing/action.php | 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) (limited to 'lib/plugins') diff --git a/lib/plugins/action.php b/lib/plugins/action.php index 885bd7c96..a2ad969d7 100644 --- a/lib/plugins/action.php +++ b/lib/plugins/action.php @@ -17,7 +17,7 @@ class DokuWiki_Action_Plugin extends DokuWiki_Plugin { /** * Registers a callback function for a given event */ - function register($controller) { + function register(Doku_Event_Handler $controller) { trigger_error('register() not implemented in '.get_class($this), E_USER_WARNING); } } diff --git a/lib/plugins/popularity/action.php b/lib/plugins/popularity/action.php index bf11efba6..1c7a2f65d 100644 --- a/lib/plugins/popularity/action.php +++ b/lib/plugins/popularity/action.php @@ -18,7 +18,7 @@ class action_plugin_popularity extends Dokuwiki_Action_Plugin { /** * Register its handlers with the dokuwiki's event controller */ - function register(&$controller) { + function register(Doku_Event_Handler $controller) { $controller->register_hook('INDEXER_TASKS_RUN', 'AFTER', $this, '_autosubmit', array()); } diff --git a/lib/plugins/safefnrecode/action.php b/lib/plugins/safefnrecode/action.php index 5d3eaae3a..aae11c437 100644 --- a/lib/plugins/safefnrecode/action.php +++ b/lib/plugins/safefnrecode/action.php @@ -13,7 +13,7 @@ require_once DOKU_PLUGIN.'action.php'; class action_plugin_safefnrecode extends DokuWiki_Action_Plugin { - public function register(Doku_Event_Handler &$controller) { + public function register(Doku_Event_Handler $controller) { $controller->register_hook('INDEXER_TASKS_RUN', 'BEFORE', $this, 'handle_indexer_tasks_run'); diff --git a/lib/plugins/testing/action.php b/lib/plugins/testing/action.php index e829847b6..a242ab0b7 100644 --- a/lib/plugins/testing/action.php +++ b/lib/plugins/testing/action.php @@ -7,7 +7,8 @@ * @author Tobias Sarnowski */ class action_plugin_testing extends DokuWiki_Action_Plugin { - function register(&$controller) { + + function register(Doku_Event_Handler $controller) { $controller->register_hook('DOKUWIKI_STARTED', 'AFTER', $this, 'dokuwikiStarted'); } -- cgit v1.2.3 From 00c2d4a9d8fcb38b6a2294749b395d528952fde5 Mon Sep 17 00:00:00 2001 From: Anika Henke Date: Sat, 28 Jul 2012 20:51:59 +0100 Subject: fixed some RTL+IE7 bugs, mainly background icons and search form (FS#2569) --- lib/plugins/acl/style.css | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'lib/plugins') diff --git a/lib/plugins/acl/style.css b/lib/plugins/acl/style.css index 2eee4f41c..7044254a5 100644 --- a/lib/plugins/acl/style.css +++ b/lib/plugins/acl/style.css @@ -74,6 +74,7 @@ div#acl_manager .aclgroup { [dir=rtl] div#acl_manager .aclgroup { background: transparent url(pix/group.png) right 1px no-repeat; padding: 1px 18px 1px 0px; + display: inline-block; /* needed for IE7 */ } div#acl_manager .acluser { @@ -83,6 +84,7 @@ div#acl_manager .acluser { [dir=rtl] div#acl_manager .acluser { background: transparent url(pix/user.png) right 1px no-repeat; padding: 1px 18px 1px 0px; + display: inline-block; /* needed for IE7 */ } div#acl_manager .aclpage { @@ -92,6 +94,7 @@ div#acl_manager .aclpage { [dir=rtl] div#acl_manager .aclpage { background: transparent url(pix/page.png) right 1px no-repeat; padding: 1px 18px 1px 0px; + display: inline-block; /* needed for IE7 */ } div#acl_manager .aclns { @@ -101,6 +104,7 @@ div#acl_manager .aclns { [dir=rtl] div#acl_manager .aclns { background: transparent url(pix/ns.png) right 1px no-repeat; padding: 1px 18px 1px 0px; + display: inline-block; /* needed for IE7 */ } div#acl_manager label.disabled { -- cgit v1.2.3 From 24d494984899eca69df2a5e50d941007500ba545 Mon Sep 17 00:00:00 2001 From: Anika Henke Date: Sun, 5 Aug 2012 12:52:25 +0100 Subject: added some missing spaces (to popularity and revert plugins) --- lib/plugins/popularity/admin.php | 2 +- lib/plugins/revert/admin.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'lib/plugins') diff --git a/lib/plugins/popularity/admin.php b/lib/plugins/popularity/admin.php index a04e98a66..364075903 100644 --- a/lib/plugins/popularity/admin.php +++ b/lib/plugins/popularity/admin.php @@ -135,7 +135,7 @@ class admin_plugin_popularity extends DokuWiki_Admin_Plugin { $form .= '' .'' .''; diff --git a/lib/plugins/revert/admin.php b/lib/plugins/revert/admin.php index ff5fa69ba..958cf5acf 100644 --- a/lib/plugins/revert/admin.php +++ b/lib/plugins/revert/admin.php @@ -64,7 +64,7 @@ class admin_plugin_revert extends DokuWiki_Admin_Plugin { echo '
'; echo ''; echo ''; - echo ''; + echo ' '; echo ' '.$this->getLang('note1').''; echo '


'; } @@ -134,7 +134,7 @@ class admin_plugin_revert extends DokuWiki_Admin_Plugin { echo ($recent['type']===DOKU_CHANGE_TYPE_MINOR_EDIT) ? '
  • ' : '
  • '; echo ''.NL; echo '
    '.NL; - echo '1)'.NL; + echo '1)'.NL; echo $this->getLang('p_include'); echo '
    '; @@ -602,7 +602,7 @@ class admin_plugin_acl extends DokuWiki_Admin_Plugin { echo ''; echo ''.$this->getLang('where').''; echo ''.$this->getLang('who').''; - echo ''.$this->getLang('perm').'1)'; + echo ''.$this->getLang('perm').'1)'; echo ''.$lang['btn_delete'].''; echo ''; foreach($this->acl as $where => $set){ @@ -630,7 +630,7 @@ class admin_plugin_acl extends DokuWiki_Admin_Plugin { echo $this->_html_checkboxes($perm,$ispage,'acl['.$where.']['.$who.']'); echo ''; - echo ''; + echo ''; echo ''; echo ''; echo ''; @@ -638,7 +638,7 @@ class admin_plugin_acl extends DokuWiki_Admin_Plugin { } echo ''; - echo ''; + echo ''; echo ''; echo ''; echo ''; @@ -746,7 +746,7 @@ class admin_plugin_acl extends DokuWiki_Admin_Plugin { } //build code - $ret .= '