From e8b5a4f91c8a6e230a6cfe13c43dc9ddce31e253 Mon Sep 17 00:00:00 2001 From: Andreas Gohr Date: Sat, 28 Jul 2012 12:02:06 +0200 Subject: fix E_STRICT errors FS#2427 This commit fixes all E_STRICT messages shown when running the test suite. There might be more problems not covered by tests, yet. For compatibility reasons with plugins, E_STRICT errors are still supressed. --- lib/plugins/action.php | 2 +- lib/plugins/popularity/action.php | 2 +- lib/plugins/safefnrecode/action.php | 2 +- lib/plugins/testing/action.php | 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) (limited to 'lib') diff --git a/lib/plugins/action.php b/lib/plugins/action.php index 885bd7c96..a2ad969d7 100644 --- a/lib/plugins/action.php +++ b/lib/plugins/action.php @@ -17,7 +17,7 @@ class DokuWiki_Action_Plugin extends DokuWiki_Plugin { /** * Registers a callback function for a given event */ - function register($controller) { + function register(Doku_Event_Handler $controller) { trigger_error('register() not implemented in '.get_class($this), E_USER_WARNING); } } diff --git a/lib/plugins/popularity/action.php b/lib/plugins/popularity/action.php index bf11efba6..1c7a2f65d 100644 --- a/lib/plugins/popularity/action.php +++ b/lib/plugins/popularity/action.php @@ -18,7 +18,7 @@ class action_plugin_popularity extends Dokuwiki_Action_Plugin { /** * Register its handlers with the dokuwiki's event controller */ - function register(&$controller) { + function register(Doku_Event_Handler $controller) { $controller->register_hook('INDEXER_TASKS_RUN', 'AFTER', $this, '_autosubmit', array()); } diff --git a/lib/plugins/safefnrecode/action.php b/lib/plugins/safefnrecode/action.php index 5d3eaae3a..aae11c437 100644 --- a/lib/plugins/safefnrecode/action.php +++ b/lib/plugins/safefnrecode/action.php @@ -13,7 +13,7 @@ require_once DOKU_PLUGIN.'action.php'; class action_plugin_safefnrecode extends DokuWiki_Action_Plugin { - public function register(Doku_Event_Handler &$controller) { + public function register(Doku_Event_Handler $controller) { $controller->register_hook('INDEXER_TASKS_RUN', 'BEFORE', $this, 'handle_indexer_tasks_run'); diff --git a/lib/plugins/testing/action.php b/lib/plugins/testing/action.php index e829847b6..a242ab0b7 100644 --- a/lib/plugins/testing/action.php +++ b/lib/plugins/testing/action.php @@ -7,7 +7,8 @@ * @author Tobias Sarnowski */ class action_plugin_testing extends DokuWiki_Action_Plugin { - function register(&$controller) { + + function register(Doku_Event_Handler $controller) { $controller->register_hook('DOKUWIKI_STARTED', 'AFTER', $this, 'dokuwikiStarted'); } -- cgit v1.2.3 From ebe6179c634de8874fe940ae1c5fe9792018d616 Mon Sep 17 00:00:00 2001 From: Anika Henke Date: Sat, 28 Jul 2012 13:03:27 +0100 Subject: fixed some RTL issues in mediamanager (FS#2433 and others) --- lib/tpl/dokuwiki/css/_media_fullscreen.css | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) (limited to 'lib') diff --git a/lib/tpl/dokuwiki/css/_media_fullscreen.css b/lib/tpl/dokuwiki/css/_media_fullscreen.css index 9054ab26f..2811f2935 100644 --- a/lib/tpl/dokuwiki/css/_media_fullscreen.css +++ b/lib/tpl/dokuwiki/css/_media_fullscreen.css @@ -53,6 +53,9 @@ margin: 0 10px 10px 0; position: relative; } +[dir=rtl] #mediamanager__page .panelContent { + text-align: right; +} #mediamanager__page .file .panelHeader, #mediamanager__page .file .panelContent { @@ -107,9 +110,17 @@ padding: 0; list-style: none; } +[dir=rtl] #mediamanager__page .namespaces ul { + margin-left: 0; + margin-right: .2em; +} #mediamanager__page .namespaces ul ul { margin-left: 1em; } +[dir=rtl] #mediamanager__page .namespaces ul ul { + margin-left: 0; + margin-right: 1em; +} #mediamanager__page .namespaces ul ul li { margin: 0; } @@ -398,6 +409,10 @@ text-align: left; border-color: __background__; } +[dir=rtl] #mediamanager__diff td, +[dir=rtl] #mediamanager__diff th { + text-align: right; +} #mediamanager__diff th { font-weight: normal; @@ -432,10 +447,6 @@ #mediamanager__diff .imageDiff { position: relative; } -#mediamanager__diff .imageDiff .image1, -#mediamanager__diff .imageDiff .image2 { - width: 97%; -} #mediamanager__diff .imageDiff .image2 { position: absolute; top: 0; @@ -451,6 +462,10 @@ overflow: hidden; } +#mediamanager__diff .imageDiff.portions img { + float: left; +} + #mediamanager__diff .imageDiff img { width: 100%; max-width: none; -- cgit v1.2.3 From 87f69c198897d8015cfb24120265d076a9b47f70 Mon Sep 17 00:00:00 2001 From: Anika Henke Date: Sat, 28 Jul 2012 13:31:36 +0100 Subject: fixed icons in buttons not showing in IE8 and below (FS#2568) --- lib/tpl/dokuwiki/css/basic.css | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'lib') diff --git a/lib/tpl/dokuwiki/css/basic.css b/lib/tpl/dokuwiki/css/basic.css index d683603ae..f33b21fbe 100644 --- a/lib/tpl/dokuwiki/css/basic.css +++ b/lib/tpl/dokuwiki/css/basic.css @@ -194,6 +194,10 @@ object { max-width: 100%; height: auto; } +/* IE8 and below won't display the images otherwise */ +button img { + max-width: none; +} hr { border-top: solid __border__; -- cgit v1.2.3 From ff10b2405470c8c9c90a18830dafb641cdee70fe Mon Sep 17 00:00:00 2001 From: Anika Henke Date: Sat, 28 Jul 2012 13:32:23 +0100 Subject: improved toolbar appearing to load slowly --- lib/scripts/edit.js | 2 ++ 1 file changed, 2 insertions(+) (limited to 'lib') diff --git a/lib/scripts/edit.js b/lib/scripts/edit.js index 33a8f61b5..5a5e829bd 100644 --- a/lib/scripts/edit.js +++ b/lib/scripts/edit.js @@ -40,6 +40,8 @@ function createToolButton(icon,label,key,id,classname){ icon = DOKU_BASE + 'lib/images/toolbar/' + icon; } $ico.attr('src', icon); + $ico.attr('width', 16); + $ico.attr('height', 16); $btn.append($ico); // we have to return a DOM object (for compatibility reasons) -- cgit v1.2.3 From c4a2059c6e88bf3055f0ba3f8e079f10c950e1b0 Mon Sep 17 00:00:00 2001 From: Anika Henke Date: Sat, 28 Jul 2012 16:04:18 +0100 Subject: added link icons back into RTL styles for old default template (FS#2524) --- lib/tpl/default/rtl.css | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'lib') diff --git a/lib/tpl/default/rtl.css b/lib/tpl/default/rtl.css index 8b2837874..fbc22f304 100644 --- a/lib/tpl/default/rtl.css +++ b/lib/tpl/default/rtl.css @@ -54,15 +54,16 @@ div.dokuwiki li ol { div.dokuwiki a.urlextern, div.dokuwiki a.interwiki, +div.dokuwiki a.mediafile, div.dokuwiki a.windows, div.dokuwiki a.mail { - /* should work but doesn't - so we just disable icons here*/ - /* background-position: right 1px; padding-right: 16px; - */ - background-image: none !important; - padding: 0px 0px 0px 0px; + padding-left: 0; +} + +div.dokuwiki a.mediafile { + padding-right: 18px; } div.dokuwiki div.secedit input.button { -- cgit v1.2.3 From 00c2d4a9d8fcb38b6a2294749b395d528952fde5 Mon Sep 17 00:00:00 2001 From: Anika Henke Date: Sat, 28 Jul 2012 20:51:59 +0100 Subject: fixed some RTL+IE7 bugs, mainly background icons and search form (FS#2569) --- lib/plugins/acl/style.css | 4 ++++ lib/tpl/default/rtl.css | 1 + lib/tpl/dokuwiki/css/_links.css | 1 + lib/tpl/dokuwiki/css/design.css | 7 +++++++ 4 files changed, 13 insertions(+) (limited to 'lib') diff --git a/lib/plugins/acl/style.css b/lib/plugins/acl/style.css index 2eee4f41c..7044254a5 100644 --- a/lib/plugins/acl/style.css +++ b/lib/plugins/acl/style.css @@ -74,6 +74,7 @@ div#acl_manager .aclgroup { [dir=rtl] div#acl_manager .aclgroup { background: transparent url(pix/group.png) right 1px no-repeat; padding: 1px 18px 1px 0px; + display: inline-block; /* needed for IE7 */ } div#acl_manager .acluser { @@ -83,6 +84,7 @@ div#acl_manager .acluser { [dir=rtl] div#acl_manager .acluser { background: transparent url(pix/user.png) right 1px no-repeat; padding: 1px 18px 1px 0px; + display: inline-block; /* needed for IE7 */ } div#acl_manager .aclpage { @@ -92,6 +94,7 @@ div#acl_manager .aclpage { [dir=rtl] div#acl_manager .aclpage { background: transparent url(pix/page.png) right 1px no-repeat; padding: 1px 18px 1px 0px; + display: inline-block; /* needed for IE7 */ } div#acl_manager .aclns { @@ -101,6 +104,7 @@ div#acl_manager .aclns { [dir=rtl] div#acl_manager .aclns { background: transparent url(pix/ns.png) right 1px no-repeat; padding: 1px 18px 1px 0px; + display: inline-block; /* needed for IE7 */ } div#acl_manager label.disabled { diff --git a/lib/tpl/default/rtl.css b/lib/tpl/default/rtl.css index fbc22f304..f16ba101b 100644 --- a/lib/tpl/default/rtl.css +++ b/lib/tpl/default/rtl.css @@ -60,6 +60,7 @@ div.dokuwiki a.mail { background-position: right 1px; padding-right: 16px; padding-left: 0; + display: inline-block; /* needed for IE7 */ } div.dokuwiki a.mediafile { diff --git a/lib/tpl/dokuwiki/css/_links.css b/lib/tpl/dokuwiki/css/_links.css index 22502f6a9..e53ba45e5 100644 --- a/lib/tpl/dokuwiki/css/_links.css +++ b/lib/tpl/dokuwiki/css/_links.css @@ -70,4 +70,5 @@ [dir=rtl] .dokuwiki a.mediafile { background-position: right center; padding: 0 18px 0 0; + display: inline-block; /* needed for IE7 */ } diff --git a/lib/tpl/dokuwiki/css/design.css b/lib/tpl/dokuwiki/css/design.css index d1a00ce0a..8a3f20729 100644 --- a/lib/tpl/dokuwiki/css/design.css +++ b/lib/tpl/dokuwiki/css/design.css @@ -103,6 +103,10 @@ padding-left: 0; padding-right: 20px; } +[dir=rtl] #IE7 #dokuwiki__usertools a.action { + display: inline-block; +} + #dokuwiki__header .mobileTools { display: none; /* hide mobile tools dropdown to only show in mobile view */ @@ -176,6 +180,9 @@ font-size: 0.875em; position: relative; } +[dir=rtl] #IE7 #dokuwiki__sitetools form.search { + min-height: 1px; +} #dokuwiki__sitetools form.search input.edit { width: 18em; padding: .35em 22px .35em .1em; -- cgit v1.2.3 From faa7bcaae749311237124cce9f20e92fe7e25291 Mon Sep 17 00:00:00 2001 From: Anika Henke Date: Tue, 31 Jul 2012 23:18:35 +0100 Subject: fixed objects not showing properly (FS#2572) --- lib/tpl/dokuwiki/css/basic.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/tpl/dokuwiki/css/basic.css b/lib/tpl/dokuwiki/css/basic.css index f33b21fbe..4942de001 100644 --- a/lib/tpl/dokuwiki/css/basic.css +++ b/lib/tpl/dokuwiki/css/basic.css @@ -188,11 +188,11 @@ img { color: #666; background-color: transparent; font-style: italic; + height: auto; } img, object { max-width: 100%; - height: auto; } /* IE8 and below won't display the images otherwise */ button img { -- cgit v1.2.3 From 24d494984899eca69df2a5e50d941007500ba545 Mon Sep 17 00:00:00 2001 From: Anika Henke Date: Sun, 5 Aug 2012 12:52:25 +0100 Subject: added some missing spaces (to popularity and revert plugins) --- lib/plugins/popularity/admin.php | 2 +- lib/plugins/revert/admin.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'lib') diff --git a/lib/plugins/popularity/admin.php b/lib/plugins/popularity/admin.php index a04e98a66..364075903 100644 --- a/lib/plugins/popularity/admin.php +++ b/lib/plugins/popularity/admin.php @@ -135,7 +135,7 @@ class admin_plugin_popularity extends DokuWiki_Admin_Plugin { $form .= '' .'' .''; diff --git a/lib/plugins/revert/admin.php b/lib/plugins/revert/admin.php index ff5fa69ba..958cf5acf 100644 --- a/lib/plugins/revert/admin.php +++ b/lib/plugins/revert/admin.php @@ -64,7 +64,7 @@ class admin_plugin_revert extends DokuWiki_Admin_Plugin { echo '
'; echo ''; echo ''; - echo ''; + echo ' '; echo ' '.$this->getLang('note1').''; echo '


'; } @@ -134,7 +134,7 @@ class admin_plugin_revert extends DokuWiki_Admin_Plugin { echo ($recent['type']===DOKU_CHANGE_TYPE_MINOR_EDIT) ? '
  • ' : '
  • '; echo ''.NL; echo '
    '.NL; - echo '1)'.NL; + echo '1)'.NL; echo $this->getLang('p_include'); echo '
    '; @@ -602,7 +602,7 @@ class admin_plugin_acl extends DokuWiki_Admin_Plugin { echo ''; echo ''.$this->getLang('where').''; echo ''.$this->getLang('who').''; - echo ''.$this->getLang('perm').'1)'; + echo ''.$this->getLang('perm').'1)'; echo ''.$lang['btn_delete'].''; echo ''; foreach($this->acl as $where => $set){ @@ -630,7 +630,7 @@ class admin_plugin_acl extends DokuWiki_Admin_Plugin { echo $this->_html_checkboxes($perm,$ispage,'acl['.$where.']['.$who.']'); echo ''; - echo ''; + echo ''; echo ''; echo ''; echo ''; @@ -638,7 +638,7 @@ class admin_plugin_acl extends DokuWiki_Admin_Plugin { } echo ''; - echo ''; + echo ''; echo ''; echo ''; echo ''; @@ -746,7 +746,7 @@ class admin_plugin_acl extends DokuWiki_Admin_Plugin { } //build code - $ret .= '